Skip to content

Add missing default.project.json #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameronpcampbell merged 3 commits into from
Sep 17, 2025
Merged

Add missing default.project.json #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
637240f
Create default.project.json
Aseminaunz Sep 1, 2025
ee1a21b
Fix spacing of `description` field in `wally.toml`
Aseminaunz Sep 1, 2025
3aaf7d1
Bump version
Aseminaunz Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions default.project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"name": "Typeforge",
"tree": {
"$path": "src"
}
}
4 changes: 2 additions & 2 deletions wally.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[package]
name = "cameronpcampbell/typeforge"
description="A Type Function utility library."
version = "2.1.0"
description = "A Type Function utility library."
version = "3.0.0"
Copy link
Collaborator

@cameronpcampbell cameronpcampbell Sep 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the version to 2.1.1 as the changes only constitutes a minor patch in my opinion. 😄

Copy link
Contributor Author

@Aseminaunz Aseminaunz Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is major because it breaks compatibility with previous versions of the package.

It breaks compatibility because, previously, to import the package (both in wally and pesde), users were required to do

local typegorge = require(pathToTypeforge.src)

which is no longer valid. Instead, it's now

local typegorge = require(pathToTypeforge)

Copy link
Contributor Author

@Aseminaunz Aseminaunz Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making this a minor patch would make uses of the package that took versions 2.x.x break

Copy link
Collaborator

@cameronpcampbell cameronpcampbell Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea, you're right - my bad.

registry = "https://github.com/UpliftGames/wally-index"
realm = "shared"
license = "MIT"
Expand Down
Loading