Don't open welcome page on extension update#240
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 16, 2025
linuz90
approved these changes
Apr 28, 2025
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Simplified the extension's onInstalled event handler to only open the welcome page on initial installation, not on updates.
What changed?
?updated=truethat was previously added for update eventshttps://typefully.com/minimal-twitter/welcomewithout any query parametersHow to test?
Why make this change?
This change improves user experience by only showing the welcome page to new users, preventing interruptions for existing users when the extension updates. This reduces potential annoyance from having the welcome page repeatedly open after extension updates.
Fix MIN-36