-
-
Notifications
You must be signed in to change notification settings - Fork 166
Add support for unix domain sockets (and peer authentication) #1192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I tried adding a test in c521068 but it fails on Mac w/ Colima due to permissions issues. The new container fails to start with this error: Tried various things (e.g. changing fstype used by Colima, symlink nonsense, etc) without luck. |
| ThisBuild / tlCiReleaseBranches += "series/0.6.x" | ||
| ThisBuild / tlCiScalafmtCheck := false | ||
| ThisBuild / tlSitePublishBranch := Some("series/0.6.x") | ||
| ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need this (anymore?)
| Tests.Argument(TestFrameworks.MUnit, "--exclude-tags=" + excludedTags.mkString(",")) | ||
| else Tests.Argument() | ||
| }, | ||
| Test / baseDirectory := (ThisBuild / Test / run / baseDirectory).value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make forked tests working directory be root of build instead of root of submodule
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1192 +/- ##
==========================================
- Coverage 83.94% 83.24% -0.70%
==========================================
Files 138 140 +2
Lines 2136 2238 +102
Branches 243 230 -13
==========================================
+ Hits 1793 1863 +70
- Misses 343 375 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prepare for Native 0.5 - update dependencies
| fs2.io.compression.fs2ioCompressionForIO | ||
| } | ||
|
|
||
| final val isJVM = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
munit.internal.PlatformCompat has appropriate isJVM/isJS/isNative since munit 1.2.0.
vendamere
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out on a project and it worked well. Looking forward to this being merged.
|
Still blocked on upstream dependencies -- need a stable build of otel4s for native 0.5 at the very least, then need production builds of CE, FS2, etc. |
Adds support for connecting to the Postgres server via unix domain sockets.
Example usage:
The above configuration results in connecting via
/tmp/.s.PGSQL.5432. Variations ofwithUnixSocketsare supplied for customizing the path.Supports both trust and peer authentication types.
TODO: Figure out how to test this with the current docker-compose based configuration