Fix: Don't crash if a message has no author#125
Merged
robertt merged 1 commit intotypescript-community:masterfrom Mar 24, 2021
Merged
Fix: Don't crash if a message has no author#125robertt merged 1 commit intotypescript-community:masterfrom
robertt merged 1 commit intotypescript-community:masterfrom
Conversation
When setting the status message, the bot looks for the prior message, to update it if it is found. To do this, it filters the message list by author id. However, sometimes a message does not have an author (unsure when; maybe when the author has left the server?), and the bot crashes. This slipped by for a long time because the types don't mark the author as nullable (although the api reference does).
Contributor
Author
|
After running into a similar error in a different place (:wastebasket: reactions to remove embeds), I believe this is a result of the message being partial, so it could be fixed by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the status message, the bot looks for the prior message, to update it if it is found. To do this, it filters the message list by author id. However, sometimes a message does not have an author (unsure when; maybe when the author has left the server?), and the bot crashes.
This slipped by for a long time because the types don't mark the author as nullable (although the api reference does).
Honestly I'm a bit surprised it didn't happen before now, since #117 didn't change this
filter