feat: exit with ExitStatus::Failure on syntax error#422
Open
lschuermann wants to merge 1 commit intotypstyle-rs:masterfrom
Open
feat: exit with ExitStatus::Failure on syntax error#422lschuermann wants to merge 1 commit intotypstyle-rs:masterfrom
lschuermann wants to merge 1 commit intotypstyle-rs:masterfrom
Conversation
Collaborator
|
I had discussed with @Enter-tainer about this behavior offline long before. We believed that typstyle was not intended as a syntax checker, so erroneous input can be silently ignored. Anyway, we can now reconsider the appropriate behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary & Changes
Makes
typstyleexit with anExitStatus::Failureupon encountering a syntax error.I am integrating it into my editor, and it was quite suprising to me seeing that
typstylewill silently ignore erroneous input. This is different from other widespread formatting tools, such asrustfmt.If there is a good reason to keep the original behavior, I'm happy to put this change behind a command line switch.
Checklist
Before submitting, please ensure you've done the following:
Testing
Needs testing.
Additional Notes