Skip to content
This repository was archived by the owner on Dec 20, 2021. It is now read-only.

optimize google chrome lighthouse stats #107

Open
ghost wants to merge 4 commits into
base: master
Choose a base branch
from
Open

optimize google chrome lighthouse stats #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
638539e
added aria-label to header link
Jun 3, 2021
67ad2b9
giving back cursor pointer after removing a href
Jun 3, 2021
f096533
changed from a href to span for lighthouse seo check
Jun 3, 2021
f05377c
Merge branch 'uPagge:master' into master
Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions assets/css/_partial/_header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
position: absolute;
left: auto;
right: 1rem;
cursor: pointer;
}

.search-toggle {
Expand Down Expand Up @@ -141,6 +142,10 @@
}
}

.theme-switch {
cursor: pointer;
}

.theme-switch i {
@include transform(rotate(225deg));
}
Expand Down
2 changes: 1 addition & 1 deletion layouts/_default/_markup/render-heading.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<h{{ .Level }} id="{{ .Anchor | safeURL }}" class="headerLink"><a href="#{{ .Anchor | safeURL }}" class="header-mark"></a>{{ .Text | safeHTML }}</h{{ .Level }}>
<h{{ .Level }} id="{{ .Anchor | safeURL }}" class="headerLink"><a href="#{{ .Anchor | safeURL }}" aria-label="{{ .Anchor | safeURL }}" class="header-mark"></a>{{ .Text | safeHTML }}</h{{ .Level }}>
28 changes: 14 additions & 14 deletions layouts/partials/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,20 +72,20 @@ <h2 class="display-hidden">Основная навигация</h2>
{{- if .Site.Params.search.enable -}}
<span class="menu-item search" id="search-desktop">
<input type="text" placeholder="{{ .Site.Params.search.placeholder | default (T `searchPlaceholder`) }}" id="search-input-desktop">
<a href="javascript:void(0);" class="search-button search-toggle" id="search-toggle-desktop" title="{{ T `search` }}">
<span class="search-button search-toggle" id="search-toggle-desktop" title="{{ T `search` }}">
<span class="svg-icon icon-search"></span>
</a>
<a href="javascript:void(0);" class="search-button search-clear" id="search-clear-desktop" title="{{ T `clear` }}">
</span>
<span class="search-button search-clear" id="search-clear-desktop" title="{{ T `clear` }}">
<span class="svg-icon icon-cancel"></span>
</a>
</span>
<span class="search-button search-loading" id="search-loading-desktop">
<span class="svg-icon icon-loading"></span>
</span>
</span>
{{- end -}}
<a href="javascript:void(0);" class="menu-item theme-switch" title="{{ T "switchTheme" }}">
<span class="menu-item theme-switch" title="{{ T "switchTheme" }}">
<span class="svg-icon icon-moon"></span>
</a>
</span>
</div>
</div>
</div>
Expand Down Expand Up @@ -129,19 +129,19 @@ <h2 class="display-hidden">Основная навигация</h2>
<div class="search-wrapper">
<div class="search mobile" id="search-mobile">
<input type="text" placeholder="{{ .Site.Params.search.placeholder | default (T `searchPlaceholder`) }}" id="search-input-mobile">
<a href="javascript:void(0);" class="search-button search-toggle" id="search-toggle-mobile" title="{{ T `search` }}">
<span class="search-button search-toggle" id="search-toggle-mobile" title="{{ T `search` }}">
<span class="svg-icon icon-search"></span>
</a>
<a href="javascript:void(0);" class="search-button search-clear" id="search-clear-mobile" title="{{ T `clear` }}">
</span>
<span class="search-button search-clear" id="search-clear-mobile" title="{{ T `clear` }}">
<span class="svg-icon icon-cancel"></span>
</a>
</span>
<span class="search-button search-loading" id="search-loading-mobile">
<span class="svg-icon icon-loading"></span>
</span>
</div>
<a href="javascript:void(0);" class="search-cancel" id="search-cancel-mobile">
<span class="search-cancel" id="search-cancel-mobile">
{{ T `cancel` }}
</a>
</span>
</div>
{{- end -}}
{{- $currentPage := . -}}
Expand All @@ -161,9 +161,9 @@ <h2 class="display-hidden">Основная навигация</h2>
{{- end -}}
</ul>
</nav>
<a href="javascript:void(0);" class="menu-item theme-switch" title="{{ T "switchTheme" }}">
<span class="menu-item theme-switch" title="{{ T "switchTheme" }}">
<span class="svg-icon icon-moon"></span>
</a>
</span>
{{- if .Site.IsMultiLingual -}}
<span onclick="javascript:void(0);" class="menu-item" title="{{ T "selectLanguage" }}">
{{- .Language.LanguageName -}}
Expand Down