Add rpc.status to client response context for annotated thrift exceptions#934
Open
deepanshumehndiratta wants to merge 3 commits intov1.4.1-hotfix-maintenancefrom
Open
Add rpc.status to client response context for annotated thrift exceptions#934deepanshumehndiratta wants to merge 3 commits intov1.4.1-hotfix-maintenancefrom
deepanshumehndiratta wants to merge 3 commits intov1.4.1-hotfix-maintenancefrom
Conversation
deepanshumehndiratta
force-pushed
the
rpc_annotation_thrift
branch
2 times, most recently
from
1b1f442 to
5509687
Compare
deepanshumehndiratta
force-pushed
the
rpc_annotation_thrift
branch
from
5509687 to
6f40277
Compare
hbhoyar-uber
reviewed
May 9, 2024
Contributor
|
Can you also add the test which shows generated code setting up this annotation |
Author
Added a unit test to cover this |
hbhoyar-uber
approved these changes
Jun 27, 2024
Contributor
hbhoyar-uber
left a comment
hbhoyar-uber
left a comment
There was a problem hiding this comment.
Nice! Looks like you refactored unnecessary code as well.
hbhoyar-uber
approved these changes
Jun 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the response status to the returned context from tchannel clients by inspecting system errors, as well as annotated applications errors (thrift exceptions)