Conversation
📝 WalkthroughWalkthroughModified the GitHub Actions deploy workflow by removing the registry-url option from the Node.js setup step and adding the --provenance flag to the npm publish command for enhanced package provenance tracking. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Free 📒 Files selected for processing (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
🔍 PR Quality Check Summary
📋 Checks Performed:
🎉 All checks passed! This PR is ready for review. |
Summary
Fixes OIDC authentication by removing
registry-urlfrom setup-node to avoidNODE_AUTH_TOKENconflict.Problem
Previous attempts failed because:
pnpm publish→ pnpm doesn't support OIDC ❌registry-url→ setup-node setsNODE_AUTH_TOKENwhich conflicts with OIDC ❌Root Cause
When
registry-urlis configured in setup-node:.npmrcautomaticallyNODE_AUTH_TOKENenvironment variableSolution - Option 1 (Simple)
Don't use
registry-url- npm CLI detects OIDC automatically:How It Works
id-token: writepermission)Changes Made
File:
.github/workflows/deploy.ymlregistry-urlfrom setup-node (avoids NODE_AUTH_TOKEN conflict)npm publishinstead ofpnpm publish(OIDC support)--provenanceflag (cryptographic attestation)Configuration Summary
id-token: writepermissionenvironment: npm-production(matches npm Trusted Publisher)npm publish --provenanceregistry-url(to avoid NODE_AUTH_TOKEN)Why This Approach
According to npm community discussions and testing:
NODE_AUTH_TOKENmanuallyWe chose Option 1 for simplicity and fewer potential conflicts.
Verification
npm Trusted Publisher configuration verified:
ubidots✅react-html-canvas✅deploy.yml✅npm-production✅References