fix(geocoder): Propogate geocoder error to consumer#487
Open
prateek3255 wants to merge 2 commits intoubilabs:mainfrom
Open
fix(geocoder): Propogate geocoder error to consumer#487prateek3255 wants to merge 2 commits intoubilabs:mainfrom
prateek3255 wants to merge 2 commits intoubilabs:mainfrom
Conversation
closes ubilabs#486 Add a new prop to propogate errors from the Geocoder.geocode API to the consumer application
|
@yfr hey, can you review this when you get the time? Our Sentry is full of these errors and thought it would be great to have a fix in the upstream. |
yfr
reviewed
Nov 29, 2021
Contributor
yfr
left a comment
yfr
left a comment
There was a problem hiding this comment.
Thank you for the PR. We had a lot on our plates but i managed to review now.
Just two small changes.
Comment on lines
+545
to
546
| const location = (gmaps?.geometry && | ||
| gmaps.geometry.location) as google.maps.LatLng; |
Contributor
There was a problem hiding this comment.
Suggested change
| const location = (gmaps?.geometry && | |
| gmaps.geometry.location) as google.maps.LatLng; | |
| const location = gmaps?.geometry?.location as google.maps.LatLng; |
Comment on lines
+577
to
+578
| const location = (gmaps?.geometry && | ||
| gmaps.geometry.location) as google.maps.LatLng; |
Contributor
There was a problem hiding this comment.
Suggested change
| const location = (gmaps?.geometry && | |
| gmaps.geometry.location) as google.maps.LatLng; | |
| const location = gmaps?.geometry?.location as google.maps.LatLng; |
Contributor
|
@prateek3255 would you like to update this pull request according to @yfr's comments, so we can get this done? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #486
Checklist