Add fourth image handling #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| required: true | ||
| type: string | ||
| image_name_four: | ||
| required: true |
Contributor
There was a problem hiding this comment.
what would happen here with a build that only has three images? Are there any other consumers of this action?
Contributor
Author
There was a problem hiding this comment.
That's a wise question. It's being used by only one service, but nothing can stop you to use it somewhere else.
Contributor
Author
There was a problem hiding this comment.
It seems like an issue with the whole approach here. Should we just mark every image after 2 as required: false? Would it mean that we have to change logic which rely on image count as well?
Contributor
|
👋🏼 @mihonninja - do you still need a review on this? Just getting round to clearing out my inbox 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.