1242 align node framework with nodescript app framework #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us HTTP server on app start
hyuko21
force-pushed
the
1242-align-node-framework-with-nodescript-app-framework
branch
from
21a3350 to
40fb885
Compare
…c auth provider/context to auth middleware
hyuko21
requested review from
MattScarthSaunders,
danielolaviobr and
inca
and removed request for
danielolaviobr and
inca
danielolaviobr
approved these changes
Aug 13, 2025
inca
approved these changes
Aug 14, 2025
Contributor
inca
left a comment
inca
left a comment
There was a problem hiding this comment.
Looks good 👍
One thought: might be worth documenting this change, so that it's easier to adapt the existing apps.
MattScarthSaunders
approved these changes
Aug 15, 2025
Contributor
MattScarthSaunders
left a comment
MattScarthSaunders
left a comment
There was a problem hiding this comment.
Looks good! 🌟
… mesh container as a service
…d reference to usage of `@nodescript/metrics`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1242