Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ubio/protocol",
"version": "7.10.1",
"version": "7.11.0",
"description": "ubio Automation Protocol",
"main": "out/main/index.js",
"types": "out/main/index.d.ts",
Expand Down
90 changes: 90 additions & 0 deletions src/schema/job-board-application.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@
"submit": {
"typeRef": "#/domains/JobBoardApplication/types/Submit"
},
"jobPostId": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed here, I might be wrong but from what I can see is that we now have jobPostId within both client and root? Might be a good idea to choose one to reduce any future confusion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. The "official" place for jobPostId was Client, but some clients integrated it in the root. Now we have to support both.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinp10 the only client that has directly integrated is CVL, who I think use jobid on applications? Other jobs are created by the recruitment-service which Jack is updating to meet the protocol requirements so this could be an opportunity to remove it at the root by the sounds of things?

"typeRef": "#/domains/JobBoardApplication/types/JobPostId"
},
"jobid": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note, this probably could be jobId instead of just jobid :D

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be a legacy thing from CVL and should only appear on their applications. Shouldn't need it if/when they migrate to the new application endpoint

"typeRef": "#/domains/JobBoardApplication/types/Jobid"
},
"applicationId": {
"typeRef": "#/domains/JobBoardApplication/types/ApplicationId"
},
"selectedDynamicQuestions": {
"typeRef": "#/domains/JobBoardApplication/types/SelectedDynamicQuestions",
"dynamic": true
Expand All @@ -42,6 +51,15 @@
}
},
"outputs": {
"resolvedUrl": {
"typeRef": "#/domains/JobBoardApplication/types/ResolvedUrl"
},
"triggerProxyEmailFallback": {
"typeRef": "#/domains/JobBoardApplication/types/TriggerProxyEmailFallback"
},
"serviceData": {
"typeRef": "#/domains/JobBoardApplication/types/ServiceData"
},
"cookies": {
"typeRef": "#/domains/Generic/types/Cookies"
},
Expand Down Expand Up @@ -103,6 +121,54 @@
},
"additionalProperties": false
},
"ResolvedUrl": {
"type": "object",
"description": "",
"properties": {
"domain": {
"type": "string",
"description": ""
},
"url": {
"type": "string",
"description": ""
}
},
"required": [
"domain",
"url"
],
"additionalProperties": false
},
"TriggerProxyEmailFallback": {
"type": "boolean",
"description": "",
"additionalProperties": false
},
"ServiceData": {
"type": "object",
"description": "The service data.",
"properties": {
"domain": {
"type": "string",
"description": ""
},
"serviceId": {
"type": "string",
"description": ""
},
"url": {
"type": "string",
"description": ""
}
},
"required": [
"domain",
"serviceId",
"url"
],
"additionalProperties": false
},
"Files": {
"type": "object",
"pii": true,
Expand All @@ -117,6 +183,21 @@
],
"additionalProperties": false
},
"JobPostId": {
"type": "string",
"description": "The ID of the job post to apply for.",
"additionalProperties": false
},
"Jobid": {
"type": "string",
"description": "The ID of the job post to apply for.",
"additionalProperties": false
},
"ApplicationId": {
"type": "string",
"description": "The ID of the application.",
"additionalProperties": false
},
"Submit": {
"type": "boolean",
"pii": false,
Expand Down Expand Up @@ -963,6 +1044,15 @@
},
"clientName": {
"type": "string"
},
"employer": {
"type": "string"
},
"jobTitle": {
"type": "string"
},
"country": {
"$ref": "#/domains/Generic/types/CountryCode"
}
},
"required": [
Expand Down