-
Notifications
You must be signed in to change notification settings - Fork 4
update JobBoards protocol #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,15 @@ | |
| "submit": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/Submit" | ||
| }, | ||
| "jobPostId": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/JobPostId" | ||
| }, | ||
| "jobid": { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just a note, this probably could be There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this might be a legacy thing from CVL and should only appear on their applications. Shouldn't need it if/when they migrate to the new application endpoint |
||
| "typeRef": "#/domains/JobBoardApplication/types/Jobid" | ||
| }, | ||
| "applicationId": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/ApplicationId" | ||
| }, | ||
| "selectedDynamicQuestions": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/SelectedDynamicQuestions", | ||
| "dynamic": true | ||
|
|
@@ -42,6 +51,15 @@ | |
| } | ||
| }, | ||
| "outputs": { | ||
| "resolvedUrl": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/ResolvedUrl" | ||
| }, | ||
| "triggerProxyEmailFallback": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/TriggerProxyEmailFallback" | ||
| }, | ||
| "serviceData": { | ||
| "typeRef": "#/domains/JobBoardApplication/types/ServiceData" | ||
| }, | ||
| "cookies": { | ||
| "typeRef": "#/domains/Generic/types/Cookies" | ||
| }, | ||
|
|
@@ -103,6 +121,54 @@ | |
| }, | ||
| "additionalProperties": false | ||
| }, | ||
| "ResolvedUrl": { | ||
| "type": "object", | ||
| "description": "", | ||
| "properties": { | ||
| "domain": { | ||
| "type": "string", | ||
| "description": "" | ||
| }, | ||
| "url": { | ||
| "type": "string", | ||
| "description": "" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "domain", | ||
| "url" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| "TriggerProxyEmailFallback": { | ||
| "type": "boolean", | ||
| "description": "", | ||
| "additionalProperties": false | ||
| }, | ||
| "ServiceData": { | ||
| "type": "object", | ||
| "description": "The service data.", | ||
| "properties": { | ||
| "domain": { | ||
| "type": "string", | ||
| "description": "" | ||
| }, | ||
| "serviceId": { | ||
| "type": "string", | ||
| "description": "" | ||
| }, | ||
| "url": { | ||
| "type": "string", | ||
| "description": "" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "domain", | ||
| "serviceId", | ||
| "url" | ||
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| "Files": { | ||
| "type": "object", | ||
| "pii": true, | ||
|
|
@@ -117,6 +183,21 @@ | |
| ], | ||
| "additionalProperties": false | ||
| }, | ||
| "JobPostId": { | ||
| "type": "string", | ||
| "description": "The ID of the job post to apply for.", | ||
| "additionalProperties": false | ||
| }, | ||
| "Jobid": { | ||
| "type": "string", | ||
| "description": "The ID of the job post to apply for.", | ||
| "additionalProperties": false | ||
| }, | ||
| "ApplicationId": { | ||
| "type": "string", | ||
| "description": "The ID of the application.", | ||
| "additionalProperties": false | ||
| }, | ||
| "Submit": { | ||
| "type": "boolean", | ||
| "pii": false, | ||
|
|
@@ -963,6 +1044,15 @@ | |
| }, | ||
| "clientName": { | ||
| "type": "string" | ||
| }, | ||
| "employer": { | ||
| "type": "string" | ||
| }, | ||
| "jobTitle": { | ||
| "type": "string" | ||
| }, | ||
| "country": { | ||
| "$ref": "#/domains/Generic/types/CountryCode" | ||
| } | ||
| }, | ||
| "required": [ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed here, I might be wrong but from what I can see is that we now have
jobPostIdwithin both client and root? Might be a good idea to choose one to reduce any future confusionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. The "official" place for
jobPostIdwasClient, but some clients integrated it in the root. Now we have to support both.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@valentinp10 the only client that has directly integrated is CVL, who I think use
jobidon applications? Other jobs are created by the recruitment-service which Jack is updating to meet the protocol requirements so this could be an opportunity to remove it at the root by the sounds of things?