Add reader mode #517
Add reader mode #517
Conversation
| } | ||
| function toggleReaderMode() { | ||
| if (browserTab.readerMode) { | ||
| browserTab.reload() |
There was a problem hiding this comment.
i thought about storing the entire dom in the makeDomReadable function, but I'm not sure it's worth the tradeoff.
I don't really understand how that'd work with something like a video that's playing (if a reference is stored in a "shadow dom", does it keep playing? etc)
|
i think eventually we will switch over to the builtin blink overlay scrollbars, the css injection scrollbar theme is a bit hacky and not as nice, so probally dont worry about them too much unless you know an easy way to make an exception for that script. |
|
I think the placment makes sense to me - but perhaps there will be people who want less items in the navigation? with that in mind it may make sense to have a disable option in settings |
|
try looking at 'stock-ebook' , 'note' icons from our suru theme |
|
stock_ebook is indeed nicer, thanks! |
2 participants
Hi!
This PR adds "Reader mode" to morph -- the readability.js file is taken straight out of Mozilla's repo here. The style and header are the bare minimum to get something usable, they could be improved.
I have absolutely no idea if the placement of my code makes any sense -- to me the 'readerMode' state should be stored in each tab, but that's likely incorrect
Attached, a video of behavior
readability.mp4