Skip to content

Rename dtb_override to dtb_autodetect#62

Open
rhythm16 wants to merge 1 commit intoubuntu:mainfrom
rhythm16:misc
Open

Rename dtb_override to dtb_autodetect#62
rhythm16 wants to merge 1 commit intoubuntu:mainfrom
rhythm16:misc

Conversation

@rhythm16
Copy link
Contributor

@rhythm16 rhythm16 commented Feb 1, 2026

This ambiguity has caused confusion, for example in https://discourse.ubuntu.com/t/faq-ubuntu-25-04-25-10-on-snapdragon-x-elite/61016/112 , dtb_override=true was suggested when false was actually required to load a custom device tree.

@askiiart
Copy link

askiiart commented Feb 3, 2026

Might wanna add an "alias" that reverses it for compatibility with preexisting scripts and such

@rhythm16
Copy link
Contributor Author

rhythm16 commented Feb 4, 2026

@askiiart thanks for your suggestion!

dtb_override is ambiguous about whether the user or stubble is doing the
overriding.

In the mean time keep cmdline option dtb_override available in order
to not break existing scripts.

Signed-off-by: Wei-Lin Chang <r09922117@csie.ntu.edu.tw>
@tobhe
Copy link
Collaborator

tobhe commented Feb 4, 2026

I think this generally makes sense and I agree the name is not perfect, but I am not convinced autodetect=false is entirely correct either.

This setting only changes one particular case: If there is already a DTB registered in EFI (usually from grub or dtbloader) then stubble will only replace it with an embedded one based on the compatible string it if override=true., so override=false means stubble won't override the previous dtb. "autodetect" sounds like it would also disable the hwid based lookup which it doesn't.

Also: If we deprecate the old one I'd say there is no need to document the old one, the only reason to keep it around is to not cause unexpected behavior changes.

@rhythm16
Copy link
Contributor Author

@tobhe Thanks for the info, sorry for posting before fully understanding the behavior, I see your point after reading the code.
What about dtb_source=stubble/efi or prefer_efi_dtb=true/false?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants