Conversation
- Bump version so it's in step with Chisel3 3.5 - Avoid error on duplicate classes - put jar in utils/bin, the same way that firrtl does assembly - add calling script ./utils/bin/macro_compiler.sh
abejgonzalez
left a comment
abejgonzalez
left a comment
There was a problem hiding this comment.
Has this been bumped and tested w/ Chipyard?
|
Is there supposed to be a script added (according to the PR description)? |
|
I don't think CY currently uses this JAR, so is the point to make it this easier to use when we move to a published version of this repo? |
|
I haven't bumped and tested in chipyard. I'll give that a try, but barstools master is now on chisel 3.5-snapshot, I think that might be a problem |
|
Not sure about the script added. I was just flushing the assembly out a bit with the firrtl convention for providing a script to run the assembled jar. I don't think CY uses this at all. The assembly process looks like @edwardcwang added it. I think assembly jars are nice because they spin up way faster than sbt, so ultimately it would be good to get chipyard to use them where feasible. |
2 participants
Assembly of a jar using main from MacroCompiler is fixed.
I don't see anywhere where this is used. So I'm not sure what may be affected by the placement
of the generated jar in ./utils/bin.