Conversation
abejgonzalez
left a comment
abejgonzalez
left a comment
There was a problem hiding this comment.
Has this been tested by bumping the submodule in CY? I'm slightly concerned about the build.sbt settings changing (I think the settings being put into buildSettings and publishSettings caused problems in the past - though I forget).
| SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
| SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} |
There was a problem hiding this comment.
Who owns these? I'm concerned that these might be lost somewhere when one of the dev's leave.
| - run: sudo apt update && sudo apt install -y gnupg | ||
| - run: echo $PGP_SECRET | base64 --decode | gpg --batch --import | ||
| env: | ||
| PGP_SECRET: ${{ secrets.PGP_SECRET }} |
There was a problem hiding this comment.
Ditto (see the next msg)
| val defaultVersions = Map( | ||
| "chisel3" -> "3.5.1", | ||
| "chisel3" -> "3.5.3", | ||
| "chisel-iotesters" -> "2.5.1" |
There was a problem hiding this comment.
Nit: Should we just bump this to 2.5.4 anyways.
| --- | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
If we are publishing to Sonatype, we should also update the readme to mention what needs to be added to peoples build.sbt files.
| addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.14.5") | ||
| addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.4.3") | ||
| addSbtPlugin("net.virtual-void" % "sbt-dependency-graph" % "0.9.2") | ||
| addSbtPlugin("io.shiftleft" % "sbt-ci-release-early" % "2.0.32") |
There was a problem hiding this comment.
Not related to this PR. I wonder if there is another plugin/CI-flow that auto-bumps the SBT versions, scala versions, etc (and if that is really needed).
2 participants
Drafting tag-based publishing flow for barstools. Example release here (https://repo1.maven.org/maven2/edu/berkeley/cs/barstools_2.12/).