This repository was archived by the owner on Apr 20, 2024. It is now read-only.
Fixed index offset in mask port mapping.#38
Merged
jwright6323 merged 2 commits intomasterfrom Feb 13, 2019
Merged
Conversation
Member
|
Do you have a unit test for this? |
jwright6323
suggested changes
Feb 13, 2019
53267c2 to
88d1249
Compare
Member
Author
Not yet. It resolved the error I was seeing with the ST28 mems in EE194, but I can come up with a unit test. |
Collaborator
|
@jamesdunn @edwardcwang I'm going to file a separate issue for the unit tests and merge this now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing index offset in mask port mapping. This was originally done in #34 but did not make it to master.
Failure looked like