Releasing reset in RecFNToIN.cpp wrapper#87
Merged
jerryz123 merged 2 commits intoucb-bar:masterfrom Sep 12, 2025
Merged
Conversation
jerryz123
approved these changes
Sep 9, 2025
Contributor
Author
|
Looks like some of CI images failed to find |
Contributor
|
I'll take a look |
Contributor
Author
Thank you @jerryz123, let me know if it is in fact something I need to fix on my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by @yildizr
I believe this has no impact in the current hardfloat implementation has the module under test
RecFNToInlooks to be combinational, so reset has no effect (berkeley-hardfloat/hardfloat/src/main/scala/RecFNToIN.scala
Line 46 in 26f00d0