fix: pin "which" dep at 2.21 & build h0b41bf4_1#2325
Merged
jkjkim merged 1 commit intoucb-bar:mainfrom Feb 27, 2026
Merged
Conversation
16 tasks
jkjkim
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tldr: the
whichpackage had a upstream update that includedset -xandset -ein its conda activation script, which breaks the user terminal when the user performs. env.shafter rebuilding the conda lockfile and resetting up Chipyard.when we regenerate the conda lock file using
${CY}/scripts/conda-lockfiles.sh(which is needed ifsysroot_linux-64=2.28version in${CY}/conda-reqs/chipyard-base.yamlis higher than the glibc (ldd --version) version on the server CY is run on -- often needed on servers w/ eda tools) it bumps thewhichpackage which to version 2.23, which contains the following in the shell script [at${CY}/.conda-env/etc/conda/activate.d] that is run during conda activation:the
set -xandset -egets sourced into the current terminal when we. env.shand breaks the user terminal.This PR pins the
whichdep inchipyard-extended.yamlto the version and build that exists in the current lockfile, sowhichdoesn't get bumped when the lockfile is rebuilt.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*for full list of labels:ci:fpga-deploy- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy- Build local FPGA bitstreams for platforms that are releasedci:disable- Disable CIchangelog:fixed