Generate missing test snapshots for Linux/Windows platforms and optimize snapshot storage #171
Conversation
…hots for non-darwin platforms Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
d-morrison
left a comment
d-morrison
left a comment
There was a problem hiding this comment.
fix failing mac workflow: https://github.com/ucdavis/serodynamics/actions/runs/20843717520/job/59885746978?pr=171
Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Fixed in dc508cf. The issue was that macOS tests use |
There was a problem hiding this comment.
these snapshot .md files are too big; use expect_snapshot_data() or expect_snapshot_file() instead of expect_snapshot_value() to fix
There was a problem hiding this comment.
Fixed in 7db01b1. Replaced expect_snapshot_value() with expect_snapshot_data() for population_params attribute, reducing snapshot .md files from 5.4M to 4.5K (99.9% reduction). Population parameters are now stored in separate CSV files (62K-1.2M each) for better version control and readability.
…ation_params to reduce snapshot file sizes - Refactored tests to snapshot population_params separately as CSV files using expect_snapshot_data() - Replaced expect_snapshot_value() calls with expect_snapshot() for remaining attributes - Deleted oversized run_mod.md snapshot files (5.4M each) - Generated new compact run_mod.md (4.5K) and population_params CSV files (62K-1.2M) - This reduces repository size and improves snapshot readability Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
| results |> | ||
| attributes() |> | ||
| rlist::list.remove(c("row.names", "fitted_residuals")) |> | ||
| expect_snapshot_value(style = "deparse") |
There was a problem hiding this comment.
Restored in fe17123. Added blank line before results |> attributes() call.
| results |> | ||
| attributes() |> | ||
| rlist::list.remove(c("row.names", "fitted_residuals")) |> | ||
| expect_snapshot_value(style = "deparse") |
There was a problem hiding this comment.
Restored in fe17123. Added blank line before results |> attributes() call.
| results |> | ||
| attributes() |> | ||
| rlist::list.remove(c("row.names", "fitted_residuals")) |> | ||
| expect_snapshot_value(style = "deparse") |
There was a problem hiding this comment.
Restored in fe17123. Added blank line before results |> attributes() call.
| results |> | ||
| attributes() |> | ||
| rlist::list.remove(c("row.names", "jags.post", "fitted_residuals")) |> | ||
| expect_snapshot_value(style = "serialize") |
There was a problem hiding this comment.
Restored in fe17123. Added blank line before results |> attributes() call.
| results |> | ||
| attributes() |> | ||
| rlist::list.remove(c("row.names", "fitted_residuals")) |> | ||
| expect_snapshot_value(style = "serialize") |
There was a problem hiding this comment.
Restored in fe17123. Added blank line before results |> attributes() call.
|
@copilot resolve conflicts with target branch |
- Added blank line before each `results |> attributes()` call to match original formatting - Addresses code review comments requesting restoration of whitespace Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
…pr-141 Resolved conflicts in tests/testthat/_snaps/run_mod.md by keeping the optimized snapshot format while incorporating upstream changes: - Updated DESCRIPTION version to 0.0.0.9048 - Improved documentation in R/Run_Mod.R - Added code comments explaining parameter handling - Changed output to tibble format - Updated snapshots to reflect tibble class and description attribute Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
d-morrison
left a comment
d-morrison
left a comment
There was a problem hiding this comment.
check out full repo (fetch depth 0) and resolve merge conflicts with target branch
Fetched complete repository history and merged target branch. Preserved optimized snapshot format (4.9K) vs target's 5.4MB. All tests passing. Co-authored-by: d-morrison <2474437+d-morrison@users.noreply.github.com>
Completed in d49488a. Unshallowed repository (fetched 23,000+ commits with full history) and created proper merge commit with target branch mon_popparams. Preserved optimized snapshot format while integrating all upstream changes. All tests passing. |
variant = darwin_variant()for platform-specific snapshotstests/testthat/_snaps/darwin/, Linux/Windows use basetests/testthat/_snaps/darwin/run_mod.mdwith macOS-specific baseline valuestests/testthat/_snaps/darwin/run_mod.mdfor macOS CIexpect_snapshot_data()forpopulation_paramsinstead ofexpect_snapshot_value()results |> attributes()calls to match original code style💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.