Conversation
smalex-z
requested changes
Nov 12, 2025
Contributor
smalex-z
left a comment
There was a problem hiding this comment.
Hey Ethan,
Great PR! Changes are great and look a lot better than before. A few changes from me and Nathan though off the visual aspect-
- Ideally we shouldn't have a white background. If you can, try to do a "cover" css property instead, where we crop out any excess. We can assume a ratio of 4:5 or 3:5, whatever looks better to you
- As for sizing, the image carousel appears a little big - Nathan and I think an ideal would probably be about 50%-75% of the current size.
- Finally, instead of clicking on an image and having popping out into a new tab, it would probably look better if we opened it into a modal.
Great PR and thanks for the work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #815
Deploy Preview: https://deploy-preview-874--jovial-pasteur-581b4a.netlify.app/
Changes
Testing
Possible Changes
Checklist