Skip to content

User location checking fixes #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thilan-tran wants to merge 1 commit into
base: main
Choose a base branch
from
+47 −53
Open

User location checking fixes #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 47 additions & 53 deletions src/containers/Map/MapScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,17 @@ const MapScreen = ({ route, navigation }: MapScreenProps) => {
async function runRequests() {
// TODO: use actual API given event id from logged in user
try {
const userLocation: Location = await findUserLocation();
let userLocation = null;
if (hasLocationPermission === 'granted') {
try {
userLocation = await findUserLocation();
} catch (err) {
// don't alert and ignore common iOS simulator bug
// where acquiring user location fails
console.log(err);
}
}

const data = await BotService.getEventBots(state.user!.eventId!);
const { botArray, botHeaderInfo, botItems } = formatEventBotsData(
data,
Expand All @@ -150,7 +160,7 @@ const MapScreen = ({ route, navigation }: MapScreenProps) => {
if (!alert) {
setAlert(true);
console.log(err);
Alert.alert('Oops', 'Could not retrieve bot/location information.', [
Alert.alert('Oops', 'Could not retrieve bot information.', [
{
text: 'Ok',
onPress: () => {
Expand Down Expand Up @@ -205,83 +215,67 @@ const MapScreen = ({ route, navigation }: MapScreenProps) => {
*/
async function findUserLocation() {
let location = await Loc.getCurrentPositionAsync({});
//console.log(location);
return {
longitude: location.coords.latitude,
latitude: location.coords.latitude,
};
}

useEffect(() => {
if (hasLocationPermission !== 'granted') {
if (
hasLocationPermission !== 'granted' &&
hasLocationPermission !== 'ignore'
) {
Permissions.askAsync(Permissions.LOCATION).then((res) => {
setLocationPermission(res.status);
if (res.status === 'granted') {
setAlert(true);
Alert.alert('Thank you', 'Location permissions granted.', [
{
text: 'Ok',
onPress: () => {
setAlert(false);
},
},
]);
}
});
}
}, [hasLocationPermission]);

useEffect(() => {
let intervalId: ReturnType<typeof setTimeout> | null = null;
if (!showMapNodes && hasLocationPermission === 'granted') {
if (!showMapNodes) {
runRequests();
intervalId = setInterval(runRequests, MAP_REFRESH_RATE);
} else if (showMapNodes) {
} else {
setMapNodesSelected();
intervalId = setInterval(setMapNodesSelected, MAP_REFRESH_RATE);
} else {
clearInterval(intervalId!!);
}
return () => {
clearInterval(intervalId!!);
};
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [showMapNodes, hasLocationPermission]);

if (hasLocationPermission !== 'granted') {
if (!alert && hasLocationPermission === 'denied') {
setAlert(true);
Alert.alert('Oops', 'No access to location permissions.', [
{
text: 'Ok',
onPress: () => {
setLocationPermission('null');
setAlert(false);
},
if (!alert && hasLocationPermission === 'denied') {
setAlert(true);
Alert.alert('Cannot Get Location', 'Continue without user location?', [
{
text: 'Continue',
onPress: () => {
setLocationPermission('ignore');
setAlert(false);
},
{
text: 'Open Settings',
onPress: () => {
setAlert(false);
if (Platform.OS == 'ios') {
// Linking for iOS
Linking.openURL('app-settings:');
} else {
// IntentLauncher for Android
IntentLauncher.startActivityAsync(
IntentLauncher.ACTION_MANAGE_ALL_APPLICATIONS_SETTINGS
);
}
},
{
text: 'Open Settings',
onPress: () => {
if (Platform.OS == 'ios') {
// Linking for iOS
Linking.openURL('app-settings:');
} else {
// IntentLauncher for Android
IntentLauncher.startActivityAsync(
IntentLauncher.ACTION_MANAGE_ALL_APPLICATIONS_SETTINGS
);
}
setTimeout(() => {
setLocationPermission('null');
},
setAlert(false);
}, 5000); // wait before checking for location permission
},
]);
}
return (
<View style={styles.container}>
<Loading loadingText={'Loading'} />
</View>
);
},
]);
}

if (loading || !markers || !headerInfo) {
Expand Down Expand Up @@ -441,14 +435,14 @@ const formatEventBotsData = (
.toFixed(0)
.toString()
.replace(/\B(?=(\d{3})+(?!\d))/g, ',')
: '0';
: null;

botHeaderInfo[bot._id] = {
topLeft: bot.name,
topRight: itemCount.toString() + ' items',
// TODO: fix distance, items sold, and bot image
bottomLeft: distance + 'm away',
bottomLeft: distance ? distance + 'm away' : '',
bottomRight: itemsSold + ' items sold',
// TODO: fix bot image
imgSrc: [Bot, Tank, Crane][idx % 3],
};

Expand Down