Conversation
| RUN if [ "$UPGRADE_MOD_AUTH_OPENIDC" = "True" ]; then \ | ||
| if [ -z "${UPGRADE_OIDC_AUTH_MOD_SRC}" ]; then \ | ||
| echo "upgrading mod_auth_openidc from upstream release package"; \ | ||
| UPGRADE_OIDC_AUTH_MOD_SRC="https://github.com/OpenIDC/mod_auth_openidc/releases/download/v2.4.16.11/mod_auth_openidc-2.4.16.11-1.el9.x86_64.rpm"; \ |
There was a problem hiding this comment.
This section will most definitely need to be updated to el10 package versions. Please refer to #138 for further hints about openidc and cjose versions supporting RHEL/Rocky 10.
There was a problem hiding this comment.
This change as with any further el10 required changes can already be introduced into the add/rocky10 branch, then we could continuously merge, prepare, and test the necessary code there before we merge it into the master branch
|
|
||
| # Adjust paramiko to reduce log noise from scans if matching patch is available | ||
| RUN cd $MIG_ROOT/mig/src/paramiko \ | ||
| && if [ -e Makefile ]; then make patch PLATFORM=el9 ; fi |
There was a problem hiding this comment.
I think this will need to use el10 here as well with a matching patch added in that mig/src/paramiko folder of the migrid repo.
There was a problem hiding this comment.
It looks like Rocky10 uses a more recent but still different paramiko 3.5 by default:
https://rhel.pkgs.org/10/epel-aarch64/python3-paramiko-3.5.0-1.el10_0.noarch.rpm.html
so it probably needs a dedicated patch in migrid mig/src/paramiko/ at least to handle the UPGRADE_PARAMIKO=False case. The existing one for 4.0 on el9 may just work if symlinked to el10.
jonasbardino
left a comment
There was a problem hiding this comment.
I added a couple of comments about things to address, in addition to the existing build failures.
Start of supporting and releasing rocky10 versions of docker-migrid