Potential fix for code scanning alert no. 2: Workflow does not contain permissions#146
Closed
jonasbardino wants to merge 1 commit intomasterfrom
Closed
Potential fix for code scanning alert no. 2: Workflow does not contain permissions#146jonasbardino wants to merge 1 commit intomasterfrom
jonasbardino wants to merge 1 commit intomasterfrom
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Contributor
Author
|
Closing and making the fix manually in #148 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ucphhpc/docker-migrid/security/code-scanning/2
To fix the issue, explicitly restrict the GITHUB_TOKEN permissions used by this workflow to the least privilege necessary. This workflow only checks out code and runs local build/test commands; it does not interact with issues, pull requests, or perform any write operations via the GitHub API. Therefore, setting
contents: readat the workflow or job level is sufficient and appropriate.The best minimal fix without changing existing behavior is:
permissionsblock at the top level of the workflow (alongsidenameandon) so it applies to all jobs that don’t override it.contents: readthere. No other scopes appear necessary given the current steps.Concretely, in
.github/workflows/ci.yml, insert:between the
name: Continuous Integrationline and theon:block (e.g., new line 2 and 3). No imports or additional methods are needed because this is purely a YAML configuration change.Suggested fixes powered by Copilot Autofix. Review carefully before merging.