Draft
Conversation
albu-diku
force-pushed
the
feature/admin-ui
branch
from
92b2461 to
7419b2e
Compare
albu-diku
force-pushed
the
feature/admin-ui
branch
2 times, most recently
from
26ce7ef to
7c2083a
Compare
This change adds a small namespace to configuraton objects that behaves like a dictonary allowing objects to made available to e.g. request handlers. Opt to do this by specialising Configuration rather than changing it directly. The rationale is to preserve a distinction between static parts of the configuration of a dpeloyment, which do no change at runtime, versus e.g. a users locale which would be different for each request though consistent for its duration. Such functionality it needed to support templates without restorting to globals within the current system architecture; only congifuration objects are already threaded through most of the places this would need to be available with the correct semantics of an instance being created wherever it is needed.
This addds the necessary logic both to maintain a store of templates and makiung them available for serving within any page via a new template object type. Make sure there is a separation of the test templates from the mainline stuff by wiring a TEMPLATES section into Configuration and reading the necessary paths via the loaded configuration. Doing so allows both source location and the cache directory to be optionally specified via the main ini file and thus are runtime accessible without hard-coding. Use this facility within the tests to adjust the paths.
assert that manage_pending_peers produces what is in it then consume it when testing the pending peers listing function
template loading and rendering works, but listing templates needs to be restored as does priming ...am most of the way convinced that per-package cache dirs want to be done as part of that preparation process and not a call to os.makedirs() when we do an average "get a template store" call
do this to avoid any changes spilling over - this seemed to be happening with the previous phrasing in the tests though it is not entirely clean to me how it can have happened given how the test support code should be
We already tarted to arrange this for pending peers, but take a moment to do this for accepted peers as well. As "User" as an infix in the assertions to avoid any potential confusion and contain the argless hint application to the loaded pickle files within the two assertion functions.
albu-diku
force-pushed
the
feature/admin-ui
branch
from
910ecac to
3c361ed
Compare
this is done to allow operation in an environment without urllib3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.