Split monolithic grid_cron daemon into a thin sbin/ wrapper with all helpers in mig/lib/#455
Draft
jonasbardino wants to merge 5 commits intonextfrom
Draft
Conversation
jonasbardino
added this to the
Migration of scripts and services to new FHSesque locations milestone
…apper with all helper functions in mig/lib/cron.py . First fundamental splitting here. Still needs various clean ups and unit test coverage to follow the guidelines for migrating to FHSesque loations.
…eturns anything and test for no exception instead.
Make configuration setup mandatory on the PatternMatchingEventHandler to ease use of configuration and logger.
jonasbardino
force-pushed
the
refactor/cron-service-to-sbin-wrapper-with-mib-lib-helpers
branch
from
538a0b0 to
9a2aa12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split monolithic
grid_cron.pydaemon into a thinsbin/grid_cron.pywrapper with all helper functions inmig/lib/cron.py.First fundamental splitting in place.
TODO: still needs various clean ups and unit test coverage to follow the guidelines for migrating to FHSesque loations.