Skip to content

Implement a simple helper to search registered peers of a given user.#476

Draft
jonasbardino wants to merge 1 commit intonextfrom
add/search-peers-helper
Draft

Implement a simple helper to search registered peers of a given user.#476
jonasbardino wants to merge 1 commit intonextfrom
add/search-peers-helper

Conversation

@jonasbardino
Copy link
Contributor

Implement a simple helper to search registered peers of a given user to help site operators quickly detect issues with peer acceptance and End date.

@jonasbardino jonasbardino self-assigned this Mar 3, 2026
@jonasbardino jonasbardino added the enhancement New feature or request label Mar 3, 2026
""" % {'name': name})


if '__main__' == __name__:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't sit comfortably with me.

First, we've generally tried to make CLI tools have a formal main() method. Second, I believe a CLI tool should be introduced in line with our new conventions which, to my understanding would suggest it be placed into the sbin directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the input 👍
The reason for this is that it's a ~99% copy/paste of the existing searchusers.py script in the same folder. I made it based on an explicit discussion with our support team colleagues about their (lack of) access to search registered peers of an employee.
Note that I intentionally left it as a draft because I wanted to record that it is something we want but didn't have time to finish it.

I see two paths ahead:
a) we fast-track the inclusion and merge (or manually install) something they can use as-is
b) we postpone it until we have a style-compliant version with unit tests in line with the FHSesque layout .

I can live with either, but agree that the long-term goal is definitely (b). I think we have the concrete use-case solved so not sure how urgently a generally available solution is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - thanks for the response, and a 👍 wrt it being a draft.

Appreciate it's meant to immediately satisfy a requirement - given it's a pressing need and knowing that we're aware we'll need to revisit it I think moving forward likely makes sense. In this case it might even be better what's here isn't "pretending" to be a solution into the future and that clarity at the outset is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants