Skip to content

Move too long code comments to line above to fix source line truncated compiler warning#360

Merged
grantfirl merged 1 commit intoufs-community:production/GFS.v17from
NickSzapiro-NOAA:ccpp_longComment_gfs
Mar 4, 2026
Merged

Move too long code comments to line above to fix source line truncated compiler warning#360
grantfirl merged 1 commit intoufs-community:production/GFS.v17from
NickSzapiro-NOAA:ccpp_longComment_gfs

Conversation

@NickSzapiro-NOAA
Copy link

Description of Changes:

Adaptation of #335 for production/GFS.v17 branch

Tests Conducted:

Explicitly state what tests were run on these changes, or if any are still pending (for README or other text-only changes, just put "None required". Make note of the compilers used, the platform/machine, and other relevant details as necessary. For more complicated changes, or those resulting in scientific changes, please be explicit!
OR Add any links to tests conducted. For example, "See ufs-community/ufs-weather-model#<pr_number>"

Dependencies:

Add any links to parent PRs (e.g. SCM and/or UFS PRs) or submodules (e.g. rte-rrtmgp). For example:

  • NCAR/ccpp-framework#<pr_number>
  • NOAA-EMC/ufsatm#<pr_number>
  • ufs-community/ufs-weather-model/#<pr_number>

Documentation:

Does this PR add new capabilities that need to be documented or require modifications to the existing documentation? If so, brief supporting material can be provided here. Contact the CODEOWNERS if your PR requires extensive updates to the documentation. See https://github.com/NCAR/ccpp-doc for Technical Documentation or https://dtcenter.org/community-code/common-community-physics-package-ccpp/documentation for the latest Scientific Documentation.

Issue (optional):

If this PR is resolving or referencing one or more issues, in this repository or elewhere, list them here. For example, "Fixes issue mentioned in #123" or "Related to bug in NCAR/other_repository#123"

Contributors (optional):

If others have contributed to this work aside from the PR author, list them here

@dpsarmie
Copy link

dpsarmie commented Mar 2, 2026

@grantfirl This PR has been tested in the UFSWM prod/GFS.v17 branch. This can be merged into the CCPP production branch when ready.

@grantfirl
Copy link
Collaborator

@NickSzapiro-NOAA This looks like a repeat of #335? I thought that this wan't going to be added to the queue?

@NickSzapiro-NOAA
Copy link
Author

The idea is this PR fixes these compiler warnings in production/GFS.v17 @grantfirl and then can wrap up fixing compiler warnings for that implementation.

We held off on this for ufs/dev in #335 as the better fix seems to be free format files (in a hackathon now-ish ??)

If ccpp-physics pushes the longer term fix, can always revert this and pick that up.
But that's just the idea. I don't know if that sounds right

@grantfirl
Copy link
Collaborator

The idea is this PR fixes these compiler warnings in production/GFS.v17 @grantfirl and then can wrap up fixing compiler warnings for that implementation.

We held off on this for ufs/dev in #335 as the better fix seems to be free format files (in a hackathon now-ish ??)

If ccpp-physics pushes the longer term fix, can always revert this and pick that up. But that's just the idea. I don't know if that sounds right

Ah, I didn't notice that this was targeted to the production branch. Sorry for the confusion on my part. Since I already reviewed #335, I'll approve here.

@grantfirl grantfirl merged commit 6002023 into ufs-community:production/GFS.v17 Mar 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants