Skip to content

fix(html): Update last modified from ui-awesome/html-attribute in related classes.#44

Merged
terabytesoftw merged 1 commit intomainfrom
fix_mini_8
Feb 16, 2026
Merged

fix(html): Update last modified from ui-awesome/html-attribute in related classes.#44
terabytesoftw merged 1 commit intomainfrom
fix_mini_8

Conversation

@terabytesoftw
Copy link
Contributor

Pull Request

Q A
Is bugfix? ✔️
New feature?
Breaks BC?

@coderabbitai
Copy link

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d051549 and c9e53b2.

📒 Files selected for processing (12)
  • CHANGELOG.md
  • src/Form/Base/BaseChoice.php
  • src/Form/InputMonth.php
  • src/Form/InputNumber.php
  • src/Form/InputPassword.php
  • src/Form/InputSearch.php
  • src/Form/InputTel.php
  • src/Form/InputText.php
  • src/Form/InputTime.php
  • src/Form/InputUrl.php
  • src/Form/InputWeek.php
  • src/Metadata/Link.php
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: composer-require-checker / PHP 8.5-ubuntu-latest
  • GitHub Check: linter / Super Linter
  • GitHub Check: phpstan / PHP 8.5-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.3-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.2-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.1-windows-2022
  • GitHub Check: phpunit / PHP 8.1-ubuntu-latest
  • GitHub Check: phpunit / PHP 8.4-ubuntu-latest
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: linter / Super Linter
🔇 Additional comments (12)
CHANGELOG.md (1)

32-32: LGTM!

Changelog entry is consistent with the existing format and accurately describes the change.

src/Form/InputUrl.php (1)

7-18: LGTM!

Import and trait usage consistently updated from HasReadonly/HasRequired to CanBeReadonly/CanBeRequired.

Also applies to: 48-51

src/Form/Base/BaseChoice.php (1)

7-7: LGTM!

HasRequired correctly replaced with CanBeRequired. Choice elements (checkbox/radio) appropriately only need required, not readonly.

Also applies to: 23-23

src/Form/InputNumber.php (1)

7-17: LGTM!

Consistent trait migration from HasReadonly/HasRequired to CanBeReadonly/CanBeRequired.

Also applies to: 46-48

src/Form/InputTel.php (1)

7-18: LGTM!

Consistent with the broader trait rename across form inputs.

Also applies to: 48-50

src/Form/InputSearch.php (1)

7-19: LGTM!

Consistent trait migration.

Also applies to: 51-53

src/Form/InputWeek.php (1)

7-16: LGTM!

Consistent trait migration.

Also applies to: 53-55

src/Form/InputTime.php (1)

7-16: LGTM!

Consistent trait migration from HasReadonly/HasRequired to CanBeReadonly/CanBeRequired.

Also applies to: 53-55

src/Form/InputPassword.php (1)

7-17: LGTM — trait migration looks correct and consistent.

Import and usage of CanBeReadonly / CanBeRequired replacing HasReadonly / HasRequired is consistent with the other form input classes in this PR.

Also applies to: 47-48

src/Form/InputText.php (1)

7-19: LGTM — consistent trait rename.

Also applies to: 48-49

src/Form/InputMonth.php (1)

7-16: LGTM — consistent trait rename.

Also applies to: 55-56

src/Metadata/Link.php (1)

7-22: LGTM — HasDisabledCanBeDisabled migration is complete and tested.

The CanBeDisabled trait is properly imported at lines 8 and 46, and the test suite confirms the disabled() method renders correctly (e.g., Link::tag()->disabled(true) produces <link disabled>). No references to HasDisabled remain in the codebase.


📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Refactor

    • Refactored internal architecture across multiple form input components and metadata elements to improve code consistency and maintainability.
  • Chores

    • Updated changelog documentation.

Walkthrough

This PR replaces deprecated "Has*" trait usage with their "CanBe*" equivalents across multiple form input classes and a metadata component, as part of bug fix #44. The changes systematically swap HasReadonly/HasRequired with CanBeReadonly/CanBeRequired in form elements, and HasDisabled with CanBeDisabled in the Link class.

Changes

Cohort / File(s) Summary
CHANGELOG Update
CHANGELOG.md
Added bug #44 entry documenting the trait update from ui-awesome/html-attribute.
Form Input Components
src/Form/Base/BaseChoice.php, src/Form/InputMonth.php, src/Form/InputNumber.php, src/Form/InputPassword.php, src/Form/InputSearch.php, src/Form/InputTel.php, src/Form/InputText.php, src/Form/InputTime.php, src/Form/InputUrl.php, src/Form/InputWeek.php
Replaced trait imports and usage: removed HasReadonly and HasRequired, added CanBeReadonly and CanBeRequired across all input form components.
Metadata Component
src/Metadata/Link.php
Replaced trait imports and usage: removed HasDisabled, added CanBeDisabled.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

bug

Poem

🐰 The traits have changed their names, you see,
From "Has" to "CanBe," now they're free!
Input forms and links aligned,
A cleaner trait structure we find!
Hop along this refactoring spree! 🌟

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating traits from HasReadonly/HasRequired/HasDisabled to CanBeReadonly/CanBeRequired/CanBeDisabled across multiple form and metadata classes.
Description check ✅ Passed The description is related to the changeset, clearly indicating this is a bugfix that does not introduce new features or break backward compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix_mini_8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d051549) to head (c9e53b2).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #44   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       140       140           
===========================================
  Files             76        76           
  Lines            326       326           
===========================================
  Hits             326       326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coderabbitai coderabbitai bot added the bug Something isn't working label Feb 16, 2026
@terabytesoftw terabytesoftw merged commit a067468 into main Feb 16, 2026
49 checks passed
@terabytesoftw terabytesoftw deleted the fix_mini_8 branch February 16, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant