-
Notifications
You must be signed in to change notification settings - Fork 138
Support for Angular v21 and a bug fix! #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lindolo25
wants to merge
15
commits into
ui-router:master
Choose a base branch
from
lindolo25:chore/ng-v21-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
versions for other packages as needed for peer dependency requirements
…update to the angular's v21
v21. this needs to be done in a separeted step as the cli requires for the git chnages to be cleared before updating packages.
_componentRef to be a readonly signal and updating ChangeDetectionStrategy to onPush. This fixes issue restoring the projected content when navigating from a child state to a state with projected content.
navigating back form a chils state.
the global test to run both zone and zoneless test suites.
zoneless aplications.
Contributor
Author
|
Hi @wawyed and @christopherthielen, I updated this PR with the recent changes to main, it is ready for review. thanks again for your time and Happy new year! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @wawyed! This PR implements support for v21 and fixes a recent bug I notice, specific for zoneless apps. I decided to add these changes together to take the least of your time. If instead you will like for me to treat it as 2 separate changes, I'll be happy to split the changes and create merge request individually.
More about the changes:
@ifas replacement for*ngIfdirective (currently deprecated) and signals specifically for the_componentRefproperty of the class.About the bug: It is only reproducable for applications configure with zoneless change detection or for UIView's instances hosted by a component configured with change detection strategy
onPush. It involves the projected content of UIViews. here is an example of the components configuration.Steps to reproduce:
Here are a few links to working examples of this bug:
Another topic:
The merge request for
sample-app-angularthat added support for v20 was never merge. I'll be adding a new PR with support for v21. ui-router/sample-app-angular#795Fixes #1010