Skip to content

Conversation

@shimwell
Copy link
Collaborator

@shimwell shimwell commented Feb 4, 2021

Proposed changes

Updating the Cubit / Trelis script that makes the DAGMC geometry thanks to suggestions from @GregVernon made over on this issue #711

Thanks very much for helping out Greg

Also noticed a few missing indents for the reflecting surfaces which I'm sure I've fixed before

We can test this locally and get it merged in to develop soon

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #713 (f860ca6) into develop (3208686) will decrease coverage by 2.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #713      +/-   ##
===========================================
- Coverage    98.87%   96.33%   -2.54%     
===========================================
  Files           68       69       +1     
  Lines         4337     4451     +114     
===========================================
  Hits          4288     4288              
- Misses          49      163     +114     
Impacted Files Coverage Δ
...tric_neutronics/make_faceteted_neutronics_model.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3208686...f860ca6. Read the comment docs.

@shimwell
Copy link
Collaborator Author

shimwell commented Feb 9, 2021

I'm half tempted to hold of on this till we get Cubit in the CI and testing becomes easier. I've still not got around to locally testing this as I've been having VPN / license server issues

@GregVernon
Copy link

GregVernon commented Feb 9, 2021

I'm half tempted to hold of on this till we get Cubit in the CI and testing becomes easier. I've still not got around to locally testing this as I've been having VPN / license server issues

I would recommend holding off on this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants