feat: add cpf field schemas #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-parker1
requested review from
NathanCummings,
adam-parker1 and
samueljackson92
samueljackson92
approved these changes
Feb 10, 2025
samueljackson92
left a comment
samueljackson92
left a comment
There was a problem hiding this comment.
This looks great to me. @NathanCummings should add his opinion as he might have stronger feedback.
Member
|
I have a few thoughts. Firstly, what do we think about the use of 'cpf'? Would it be more descriptive and make more sense to call it something like "shot-summary"? |
Collaborator
I imagine it is mainly for historic use, I am not sure about other facilities but MAST and JET use CPF, I wouldn't be surprised if the other experiments do the same |
khalsz
force-pushed
the
cpf-field-schema
branch
2 times, most recently
from
fb18b27 to
1439c95
Compare
khalsz
force-pushed
the
cpf-field-schema
branch
from
1439c95 to
233fd3a
Compare
khalsz
force-pushed
the
cpf-field-schema
branch
from
2cac6d7 to
6cd252d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.