Open
Conversation
Added image thumbnails, made css and less files for when it is configured properly
ummahusla
requested changes
Oct 16, 2017
Owner
ummahusla
left a comment
ummahusla
left a comment
There was a problem hiding this comment.
I guess assets folder should be moved either to /examples/assets or should be removed completely and just replace with the URL of the random images (e.g. https://placeholder.com)
ummahusla
requested changes
Oct 17, 2017
Owner
ummahusla
left a comment
ummahusla
left a comment
There was a problem hiding this comment.
Can you please compile .css file into .min.css as well, thanks
Owner
|
Merge conflicts as well, as I've just merged a huge PR. Please take a look at it. |
Owner
|
@AntonyFenton have you had a chance to sort these conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added image thumbnails, made scss and less files for when it is
configured properly