ci: harden workflows, upgrade actions, fix caching#248
Open
paskal wants to merge 1 commit intoumputun:masterfrom
Open
ci: harden workflows, upgrade actions, fix caching#248paskal wants to merge 1 commit intoumputun:masterfrom
paskal wants to merge 1 commit intoumputun:masterfrom
Conversation
paskal
force-pushed
the
ci/workflow-hardening
branch
2 times, most recently
from
57e3420 to
0b58602
Compare
- Add permissions blocks (contents: read/write, packages: write) - Add persist-credentials: false to checkout steps - Upgrade actions (checkout v6, setup-buildx v4, login v4, build-push v7, upload-artifact v7, download-artifact v8, goreleaser v7) - Move checkout before setup-go for proper caching - Combine goveralls install with coverage submission - Add defer cancel() for context leak in main.go - Revert context.WithoutCancel in mgmt shutdown (context.Background is intentional — ctx is already canceled)
paskal
force-pushed
the
ci/workflow-hardening
branch
from
0b58602 to
7710f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
permissions: contents: readfor least-privilege security (release.yml getscontents: write, docker/ci-site getpackages: write)persist-credentials: falseto checkout stepsNote: golangci-lint v2.11.1 reports 2 code-level gosec G118 issues that exist on master — not introduced by this PR.
Verified golangci-lint config is valid with v2.11.1.