-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add Twitter OG tags support and update README (#12) #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Implement auto-generation of Twitter meta tags from Open Graph data - Add logic to map twitter:title, twitter:description, and twitter:image - Update README.md with documentation for the new Twitter tag features
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughAdds Twitter Card support: when Open Graph props are set, corresponding Twitter meta tags (title, description, image, card) are generated. Documentation (English and Korean) updated; ReactHeadSafe now populates Twitter tags; tests added; package version bumped. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/ReactHeadSafe.tsx`:
- Around line 47-61: Add unit tests that mirror the existing meta-tag tests but
target the auto-generated Twitter tags created by ReactHeadSafe when ogTitle,
ogDescription, and ogImage props are provided: assert that twitter:title,
twitter:description, twitter:image are created when
ogTitle/ogDescription/ogImage are set, that twitter:card is set to
"summary_large_image" when ogImage is provided, that updating
ogTitle/ogDescription/ogImage updates the corresponding twitter:* meta tags, and
that rerendering does not create duplicate twitter:* tags; reference the
ReactHeadSafe component and the ogTitle, ogDescription, ogImage prop behavior
(and updateMetaTag logic) when adding these tests and follow the same
structure/assertions used for the existing Open Graph meta tag tests.
Summary by CodeRabbit
New Features
Documentation
Tests
Chores