Debug in when load parameters and when different sensors assigned to …#109
Open
massarczyk wants to merge 2 commits intounc-enap:masterfrom
Open
Debug in when load parameters and when different sensors assigned to …#109massarczyk wants to merge 2 commits intounc-enap:masterfrom
massarczyk wants to merge 2 commits intounc-enap:masterfrom
Conversation
added 2 commits
June 1, 2023 12:10
…PID, added heater control and loading of current settings from the controller
Contributor
|
Ralph, this pull request has conflicts. I'm very tied up with the NSF proposal and also supposed to be on vacation this week. I would suggest you email Mark Howe and have him take a look with you. |
Author
|
Will do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the lake shore controller command when loading parameters that it froze since the line wasnt ended with \r or \n
Also heaters were only responding to settings in line 1 and two, even if input was changed
Added some new features:
Activate the heater via ORCA by setting the heaterRange
SetPoints are read out from the inputs selected
added a readout button to read out all the settings from the LakeShore since the poll only updates Temperature and heater loads (load parameters did only write settings to the lakeshore from ORCA)
Added 205M ISEG VME-based power module (basically a 224 copy)
found a bug in the 224 (and 205copy) The stop button of Ch2 had the tag of channel1