Skip to content

Conversation

@UnstoppableMango
Copy link
Contributor

Remove the make stuff for now. It doesn't work, and it makes the build more confusing.

Copilot AI review requested due to automatic review settings November 28, 2025 22:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the make integration functionality from the project. The integration attempted to provide GNU make plugin functionality but was non-functional and complicated the build process.

Key changes:

  • Removed all make integration source code from pkg/make/ directory
  • Removed the github.com/unmango/gnumake-go dependency from Go modules
  • Updated the Makefile to remove make plugin build targets

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/make/mk_funcs/main.go Deleted Go plugin loader for GNU make integration
pkg/make/mk_funcs/gpl.c Deleted GPL compatibility marker required for make plugins
pkg/make/mk_funcs.go Deleted make function implementations
pkg/make/make.go Deleted make-related constants and types
go.mod Removed github.com/unmango/gnumake-go dependency
go.sum Removed checksums for the gnumake-go dependency
Makefile Removed -load bin/mk_funcs.so directive and bin/mk_funcs.so build target
pkg/renovate/zz_generated.schema.go Auto-generated Renovate schema updates (unrelated to make removal - appears to be from schema regeneration)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@UnstoppableMango UnstoppableMango merged commit 86adf8e into main Nov 28, 2025
3 checks passed
@UnstoppableMango UnstoppableMango deleted the remove-make branch November 28, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant