Update spaceship client and add hashcash file to fix email+password login issues #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-mighty
approved these changes
Oct 25, 2024
addbrick
added
DO NOT MERGE
CURRENT MIGHTY PRODUCTION BRANCH
|
Consider rebasing this PR to work off |
alexmighty
reviewed
Oct 25, 2024
|
|
||
| def perform_login_method(user, password, modified_cookie) | ||
| do_legacy_signin = ENV['FASTLANE_USE_LEGACY_PRE_SIRP_AUTH'] | ||
| if do_legacy_signin |
alexmighty
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I debugged the stack trace from the
PEM::ExtendedManager.logincall which is throwing the error. I compared the files in the stack to the ones in the latest fastlane, only one file was changed, the spaceship client. It looks like more encryption support for stuff Apple is doing. This adds just the minimal changes required. It only touches the email+password login. It does not touch anything related to the official api use (ConnectApi in Fastlane world) or in-app purchases.For the item added to the Gemfile. That is added in the
fastlane.gemspecin newer versions of fastlane, but that file was drastically different from the one on our version, so opted just to include it as a normal gem.