Skip to content

Remove animation playback speed from serializer #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
untoldengine merged 1 commit into from
Jan 15, 2026
Merged

Remove animation playback speed from serializer #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions Sources/UntoldEngine/Scenes/SceneSerializer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ struct EntityData: Codable {
var axisOfRotations: simd_float3 = .zero
var scale: simd_float3 = .one
var animations: [URL] = []
var animationPlaybackSpeed: Float = 1.0
var mass: Float = .init(1.0)
var lightData: LightData? = nil
var cameraData: CameraData? = nil
Expand Down Expand Up @@ -264,7 +263,6 @@ public func serializeScene() -> SceneData {
// Animation properties
if let animationComponent = scene.get(component: AnimationComponent.self, for: entityId) {
entityData.animations = animationComponent.animationsFilenames
entityData.animationPlaybackSpeed = animationComponent.playbackSpeed
}

entityData.hasAnimationComponent = hasComponent(entityId: entityId, componentType: AnimationComponent.self)
Expand Down Expand Up @@ -650,7 +648,6 @@ public func deserializeScene(sceneData: SceneData, meshLoadingMode: MeshLoadingM
}
if let animationComponent = scene.get(component: AnimationComponent.self, for: entityId) {
animationComponent.animationsFilenames = sceneDataEntity.animations
animationComponent.playbackSpeed = sceneDataEntity.animationPlaybackSpeed
}
}
case .asyncDefault:
Expand All @@ -670,7 +667,6 @@ public func deserializeScene(sceneData: SceneData, meshLoadingMode: MeshLoadingM
}
if let animationComponent = scene.get(component: AnimationComponent.self, for: entityId) {
animationComponent.animationsFilenames = sceneDataEntity.animations
animationComponent.playbackSpeed = sceneDataEntity.animationPlaybackSpeed
}
}
} else {
Expand All @@ -697,7 +693,6 @@ public func deserializeScene(sceneData: SceneData, meshLoadingMode: MeshLoadingM
}
if let animationComponent = scene.get(component: AnimationComponent.self, for: entityId) {
animationComponent.animationsFilenames = sceneDataEntity.animations
animationComponent.playbackSpeed = sceneDataEntity.animationPlaybackSpeed
}
}
case .asyncDefault:
Expand All @@ -718,7 +713,6 @@ public func deserializeScene(sceneData: SceneData, meshLoadingMode: MeshLoadingM
}
if let animationComponent = scene.get(component: AnimationComponent.self, for: entityId) {
animationComponent.animationsFilenames = sceneDataEntity.animations
animationComponent.playbackSpeed = sceneDataEntity.animationPlaybackSpeed
}
}
} else {
Expand Down
Loading