Skip to content

Migrate major version v2#57

Open
tomassatka wants to merge 1 commit intoupbound:mainfrom
tomassatka:main
Open

Migrate major version v2#57
tomassatka wants to merge 1 commit intoupbound:mainfrom
tomassatka:main

Conversation

@tomassatka
Copy link

Description of your changes

Since provider-vault is already beyond v2.0.0 it has to follow versioning principles for golang: https://go.dev/blog/v2-go-modules

Otherwise it causes issue when trying to use a go.mod dependency

When i first try to fetch it as dependency i get:

tomas@Tomass-MacBook-Pro svcs % go mod tidy
go: errors parsing go.mod:
go.mod:9:2: require github.com/upbound/provider-vault: version "v2.0.1" invalid: should be v0 or v1, not v2

That is confirmed by listing it:

tomas@Tomass-MacBook-Pro svcs % go list -m -versions github.com/upbound/provider-vault

github.com/upbound/provider-vault v0.1.0 v0.2.0 v0.3.0 v0.4.0 v1.0.0

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Executed all major make commands successfuly

@Upbound-CLA
Copy link

Upbound-CLA commented Jan 29, 2025

CLA assistant check
All committers have signed the CLA.

@tomassatka tomassatka force-pushed the main branch 3 times, most recently from 0c91de3 to fb31861 Compare February 3, 2025 09:40
Signed-off-by: Tomas Satka <satka.tomas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants