Conversation
Signed-off-by: Tobias Schlaepfer <tobias.schlaepfer@iothentix.ch>
|
@turkenf I did as you said and created a new branch. I ran |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Ok, @tschlaepfer, now I am running |
|
@turkenf Thanks for fixing the code, so I guess I'm missing something (doing wrong) in my local setup. Do you have any idea what it might be? |
|
I am interested in this change, do you have a release timeline? |
| name: example-intermediate-ca-sign | ||
| spec: | ||
| forProvider: | ||
| backend: example |
There was a problem hiding this comment.
I think it would be cool to add a backendRef option to the SecretBackendRootSignIntermediate too. This is the case for many other resources.
Description of your changes
This change introduces a new reference parameter for the SecretBackendRootSignIntermediate and SecretBackendIntermediateSetSigned objects which enables the creation of a CA certificate chain using the HashiCorp Vault provider.
For the SecretBackendRootSignIntermediate object, the new parameter allows to reference a SecretBackendIntermediateCertRequest object, from which the "csr" parameter is fetched.
For the SecretBackendIntermediateSetSigned object, the new parameter allows to reference a SecretBackendIntermediateSetSigned object, from which the "certificate" parameter is fetched.
The MR also includes an example of creating a CA chain using the new reference parameters.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
See #40