Skip to content

add references for ca resources#73

Open
tschlaepfer wants to merge 2 commits intoupbound:mainfrom
tschlaepfer:reference-ca-resources
Open

add references for ca resources#73
tschlaepfer wants to merge 2 commits intoupbound:mainfrom
tschlaepfer:reference-ca-resources

Conversation

@tschlaepfer
Copy link

Description of your changes

This change introduces a new reference parameter for the SecretBackendRootSignIntermediate and SecretBackendIntermediateSetSigned objects which enables the creation of a CA certificate chain using the HashiCorp Vault provider.

For the SecretBackendRootSignIntermediate object, the new parameter allows to reference a SecretBackendIntermediateCertRequest object, from which the "csr" parameter is fetched.

For the SecretBackendIntermediateSetSigned object, the new parameter allows to reference a SecretBackendIntermediateSetSigned object, from which the "certificate" parameter is fetched.

The MR also includes an example of creating a CA chain using the new reference parameters.

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

See #40

Signed-off-by: Tobias Schlaepfer <tobias.schlaepfer@iothentix.ch>
@tschlaepfer
Copy link
Author

@turkenf I did as you said and created a new branch. I ran make generate and make reviewable. The differences in the code look like they are the same.

Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Copy link
Contributor

turkenf commented Mar 14, 2025

@turkenf I did as you said and created a new branch. I ran make generate and make reviewable. The differences in the code look like they are the same.

Ok, @tschlaepfer, now I am running make generate and then I will push the changes. If there are no pipeline problems, we can review your change.

@tschlaepfer
Copy link
Author

@turkenf Thanks for fixing the code, so I guess I'm missing something (doing wrong) in my local setup. Do you have any idea what it might be?

@simonostendorf
Copy link

I am interested in this change, do you have a release timeline?

name: example-intermediate-ca-sign
spec:
forProvider:
backend: example

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cool to add a backendRef option to the SecretBackendRootSignIntermediate too. This is the case for many other resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants