Fix #handler.applyFilters & update Search component#265
Merged
OwenCoogan merged 2 commits intomasterfrom Feb 4, 2026
Merged
Conversation
Miexil
requested review from
edouardmisset and
olxmpe
and removed request for
a team
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on January 28. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Miexil
force-pushed
the
mb/fix-applyfilters-update-search
branch
from
f493deb to
5dbf327
Compare
OwenCoogan
approved these changes
Jan 23, 2026
aprentout
approved these changes
Jan 23, 2026
phndiaye
approved these changes
Jan 23, 2026
JulienVannier66
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The
applyFiltersmethod of the v2 handler was expected to keep previously applied filters and to update or push new values when needed. It turns out the previous implementation always removed existing filters. Part of this PR fixes the issue and tests have been updated accordingly.The Search component (often used based on our Profile name column) did not take into account that said column could have multiple filters. It previously selected the first item in the filters array. This update finds the proper matching filter (if any) and sets it in the input in the constructor.
Good PR checklist