x/sqlbuilder: Add QueryRow API to the InsertExecer type#44
Merged
AlexisMontagne merged 2 commits intomasterfrom Apr 24, 2025
Merged
x/sqlbuilder: Add QueryRow API to the InsertExecer type#44AlexisMontagne merged 2 commits intomasterfrom
AlexisMontagne merged 2 commits intomasterfrom
Conversation
AlexisMontagne
requested review from
FlorianRichardUPF and
pauloestrella1994
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Statement InsertStatement | ||
| } | ||
|
|
||
| type errScanner struct { |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
the error type name errScanner should conform to the xxxError format (errname)
DarkMiMolle
reviewed
Apr 24, 2025
DarkMiMolle
left a comment
DarkMiMolle
left a comment
There was a problem hiding this comment.
That helps a lot !
Unfortunately the RETURNING clause seems to not be handled.
| case 1: | ||
| if !is.isQuery { | ||
| qw.vs = append(qw.vs, is.Returning) | ||
| break |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
break with no blank line before (nlreturn)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to leverage complex insert queries with complex returning cluases having a
QueryRowAPI should go a long wayWhat are the observable changes?
Good PR checklist
Additional Notes