Fix Calibration Curve Times with Mixed Inputs#265
Conversation
…e_times The `_build_initial_df_for_times` function now correctly handles cases where `probs` is a dictionary and `reals` and `times` are polars Series. This is achieved by relaxing the type check to allow for both NumPy arrays and polars Series. This change fixes a `TypeError` that occurred when calling `create_calibration_curve_times` with mixed input types, as reported by the user. An additional test case has been added to cover this scenario and prevent future regressions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
uriahf
deleted the
245-add-updated-functions-create_calibration_curve-and-create_calibration_curve_times-6690867222810794807
branch
1 participant
This change fixes a bug in the
create_calibration_curve_timesfunction that caused aTypeErrorwhenprobswas a dictionary andrealsandtimeswere polars Series. The fix involves updating the type checking in the_build_initial_df_for_timesfunction to correctly handle these mixed input types. A new test case has been added to ensure this scenario is covered.PR created automatically by Jules for task 6690867222810794807 started by @uriahf