🔧 Fix check_needs_data not checking remote files in needimport#1557
🔧 Fix check_needs_data not checking remote files in needimport#1557
check_needs_data not checking remote files in needimport#1557Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1557 +/- ##
==========================================
+ Coverage 86.87% 87.95% +1.07%
==========================================
Files 56 70 +14
Lines 6532 9606 +3074
==========================================
+ Hits 5675 8449 +2774
- Misses 857 1157 +300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chrisjsewell
left a comment
chrisjsewell
left a comment
There was a problem hiding this comment.
great work! Indeed it looks like a mistake
chrisjsewell
changed the title
check_needs_data not checking remote files
chrisjsewell
changed the title
check_needs_data not checking remote filescheck_needs_data not checking remote files in needimport
| errors = check_needs_data(needs_import_list) | ||
| if errors.schema: | ||
| logger.info( | ||
| f"Schema validation errors detected in file {correct_need_import_path}:" |
There was a problem hiding this comment.
ah actually correct_need_import_path is only available from the local file path if/esle branch, so this needs to now account for also pointing to the remote path
After discussing with @chrisjsewell this PR was created to use
check_needs_datato also validate remote jsons(was previously indented and was only happening for the else case)