Skip to content

👌 Default values of extra fields now checked against schema definitions#1647

Merged
chrisjsewell merged 3 commits intomasterfrom
reduce-need-extra
Feb 9, 2026
Merged

👌 Default values of extra fields now checked against schema definitions#1647
chrisjsewell merged 3 commits intomasterfrom
reduce-need-extra

Conversation

@chrisjsewell
Copy link
Member

@chrisjsewell chrisjsewell commented Feb 9, 2026

Previously, user set defaults were not being checked against schema, which is not intuitive.
As can be seen in this PR, this does not actually break any tests, principally due to the preceding #1644 and #1645

This stops user set defaults from being checked against schema.
As can be seen in this PR, this does not actually break any tests,
principally due to the preceding #1644 and #1645
@chrisjsewell chrisjsewell changed the title 🔧 Do not remove default values of extra fields in reduce_needs ‼️ Default values of extra fields are now checked against schema definitions Feb 9, 2026
@chrisjsewell chrisjsewell changed the title ‼️ Default values of extra fields are now checked against schema definitions ‼️ Default values of extra fields now checked against schema definitions Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.80%. Comparing base (4e10030) to head (23a85dd).
⚠️ Report is 240 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1647      +/-   ##
==========================================
+ Coverage   86.87%   88.80%   +1.92%     
==========================================
  Files          56       70      +14     
  Lines        6532     9989    +3457     
==========================================
+ Hits         5675     8871    +3196     
- Misses        857     1118     +261     
Flag Coverage Δ
pytests 88.80% <100.00%> (+1.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisjsewell chrisjsewell changed the title ‼️ Default values of extra fields now checked against schema definitions 👌 Default values of extra fields now checked against schema definitions Feb 9, 2026
@chrisjsewell chrisjsewell requested a review from ubmarco February 9, 2026 16:02
@chrisjsewell chrisjsewell merged commit 2f34380 into master Feb 9, 2026
21 checks passed
@chrisjsewell chrisjsewell deleted the reduce-need-extra branch February 9, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants