add CMake variables PICOWOTA_ENTRY_PIN#4
Open
kisChang wants to merge 2 commits intousedbytes:mainfrom
Open
Conversation
usedbytes
reviewed
Apr 2, 2023
CMakeLists.txt
Outdated
| message("Building in WiFi AP mode.") | ||
| endif() | ||
|
|
||
| if (BOOTLOADER_ENTRY_PIN) |
Owner
There was a problem hiding this comment.
Please use the picowota_retrieve_variable() helper, like the other variables, and can we use a similar name? Like PICOWOTA_ENTRY_PIN
usedbytes
reviewed
Apr 2, 2023
main.c
Outdated
| }; | ||
|
|
||
| #ifndef BOOTLOADER_ENTRY_PIN | ||
| #warning "BOOTLOADER_ENTRY_PIN not defined" |
Owner
There was a problem hiding this comment.
Probably not worth warning about this
usedbytes
requested changes
Apr 2, 2023
Owner
usedbytes
left a comment
usedbytes
left a comment
There was a problem hiding this comment.
I think this is a good proposal, just some minor comments about the implementation.
Also, I think we need to make sure that it works properly when the variable is defined, but defined to be 0; I'm not sure how if (BOOTLOADER_ENTRY_PIN) will act in that case
Author
|
good opinion😃 |
kisChang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split and submit from pr3, I am not familiar with CMake, I don't know what big impact this change will bring