Open
Conversation
Owner
|
Code looks good - would you mind adding a slightly more descriptive commit message though? More-or-less what you wrote on #5 would be useful context for people reading the git log |
Before this change, picowota would ignore data on the tcp connection if it is sent immediately after the connection was opened. The reason why that happens happens: - Client connects - tcp_comm_client_init is called - the gpio led turns on (tcp_comm.c#L461) - While communicating with the cyw43 to enable the led, network packages are discovered that need to be processed, incl. the initial opcode. - the recv-callback is not set yet, so the callback invocation is skipped - tcp_comm_client_init continues to set up callbacks, the initial data is lost. To resolve this, the code that turns the LED on and off is dispatched into the mainloop, so it is never called from within a networking callback.
felixdoerre
force-pushed
the
dispatch_led
branch
from
ef6737f to
c50d8db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of #5. For rationale see that issue.