Fix vector search: optimize zvec collections after upserts#225
Merged
user1303836 merged 3 commits intomainfrom Mar 7, 2026
Merged
Fix vector search: optimize zvec collections after upserts#225user1303836 merged 3 commits intomainfrom
user1303836 merged 3 commits intomainfrom
Conversation
zvec requires optimize() to compact WAL data into indexed segments. Without it, queries fail with "vector indexer not found for field embedding" because unindexed WAL segments have no vector indexer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimize()calls after every zvec upsert (single and batch) for both articles and message_chunks collectionsclose()to ensure remaining WAL data is indexedThe root cause of
vector indexer not found for field embeddingerrors: zvec writes data to a WAL (write-ahead log) on upsert, but the WAL data is not searchable untiloptimize()compacts it into indexed segments. Without optimization, queries against unindexed WAL segments fail at the C++ layer (segment.cc:711).Evidence from disk confirmed this --
message_chunkshad a 48MB unindexed WAL from today alongside an old index from Mar 2, andarticleshad a completely empty segment directory.Test plan
test_vector_store.pytests pass (upsert, search, batch, delete, reopen)