Clarify /search similarity score wording#232
Merged
user1303836 merged 2 commits intomainfrom Mar 8, 2026
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
user1303836
commented
Mar 8, 2026
Owner
Author
user1303836
left a comment
user1303836
left a comment
There was a problem hiding this comment.
Review
Overall
Clean, minimal, correct change.
The old display was misleading -- zvec cosine similarity scores aren't percentages and can vary outside 0-1 depending on the metric. Showing the raw score with a clear "Similarity score" label is more honest.
Test coverage is good: asserts both the positive case ("Similarity score: 0.95" present) and negative case ("Relevance:" absent).
CI
Lint failure is pre-existing (same 7 unrelated files on main). Tests and type checks pass.
Verdict
Ship it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/searchTesting
PYTHONPATH=/Users/user1303836/Development/intelstream-codex-search-score-ui/src /Users/user1303836/Development/intelstream/.venv/bin/pytest tests/test_discord/test_search.py -q/Users/user1303836/Development/intelstream/.venv/bin/ruff check src/intelstream/discord/cogs/search.py tests/test_discord/test_search.py/Users/user1303836/Development/intelstream/.venv/bin/ruff format --check src/intelstream/discord/cogs/search.py tests/test_discord/test_search.pyCloses #230